[Cbe-oss-dev] [PATCH 2/2] ps3fb: fix deadlock on kexec()

Jeremy Kerr jk at ozlabs.org
Fri Jan 11 13:59:32 EST 2008


Hi Geert,

> Perhaps ps3fb_release() should do
>
> 	if (!try_acquire_console_sem()) {
> 		ps3fb_sync();
> 		release_console_sem();
> 	}
>
> This would do the sync on a normal close, but not on special cases
> (console unbind, e.g. shutdown and kexec).
>
> What do you think?
>
> BTW, if we want these fixes in 2.6.24, we probably have to send it
> ASAP (tomorrow?).

Agreed - either way is fine with me, as long as we can kexec :D

Perhaps we can do the simple ps3fb fix for .24, then fix the fbmem 
fb_release calling conventions in .25.

Cheers,


Jeremy



More information about the cbe-oss-dev mailing list