[Cbe-oss-dev] [patch 3/4] MARS: Fix build warnings

Geoff Levand geoffrey.levand at am.sony.com
Sun Aug 31 13:32:23 EST 2008


On 08/24/2008 07:33 PM, Kazunori Asayama wrote:
> Geoff Levand wrote:
>> --- a/src/host/lib/mars_task.c
>> +++ b/src/host/lib/mars_task.c
>> @@ -95,7 +95,7 @@ int mars_task_initialize(struct mars_con
>>  				(struct mars_workload_context *)&task,
>>  				MARS_WORKLOAD_TYPE_TASK);
>>  	MARS_CHECK_CLEANUP_RET(ret == MARS_SUCCESS,
>> -				free((void *)task.context_save_area), ret);
>> +			free((void *)(uintptr_t)task.context_save_area), ret);
>>  	MARS_PRINT_TASK_CONTEXT(&task);
> 
> I suggest using a macro or a static inline function to convert EA 
> from/to pointer.

Yes, I had already asked Yuji to make those and to use them throughout.
Andrew's suggestion is nice, in that it does the check.

-Geoff






More information about the cbe-oss-dev mailing list