[Cbe-oss-dev] [PATCH 5/10] MARS: task queue push pop cleanup

[Yuji Mano]

Geoff Levand wrote:
> Yuji Mano wrote:
>> +
>> +	/* increment queue count */
>> +	queue->count++;
>> +
>> +	/* increment queue push ea */
>> +	queue->push_ea += queue->size;
>> +
>> +	/* wrap to front of queue if necessary */
>> +	if (queue->push_ea == queue->buffer_ea + (queue->size * queue->depth))
> 
> Operator precedence is * then + then ==, so these parenthesis are not needed.

It's more clear to me visually when I see the parenthesis and leaves room for
less careless mistakes later when I might need to make changes to the line.

I don't think there is any harm in having the parenthesis there.

Regards,
Yuji