[Cbe-oss-dev] [patch 2/4] MARS: Build file cleanup

[Kazunori Asayama]

Geoff Levand wrote:
> Cleanup build files:
>  o Use the git revision for package version.
>  o Add configure options --with-mars-host and --with-mars-mpu to support
>    platform specific builds.

It seems to be complicated, and additionally, I don't think all
combinations of hosts and MPUs will be allowed. Isn't
'--with-mars-platform' sufficient?

>  o Add host lib configure option --with-mars-kernel to allow building with
>    custom kernels.

Please explain the case that this option is needed. What is 'custom
kernel'? Isn't it 'over-design'?

(snip)
> --- a/src/host/lib/Makefile.am
> +++ b/src/host/lib/Makefile.am
(snip)
> +AM_CFLAGS =                            \
> + $(extra_cflags)                       \
> + -g                                    \
> + -Wall                                 \
> + -W                                    \
> + -Wunused                              \
> + -Wstrict-prototypes                   \
> + -Wmissing-prototypes                  \
> + -Wmissing-declarations                \
> + -Wredundant-decls                     \
> + -Winline
> +
> +AM_LDFLAGS =                           \
> + $(extra_ldflags)
> +
(snip)
> -libmars_la_CFLAGS = \
> -	$(HOST_FLAGS)
> -	-Wall \
> -	-Wunused \
> -	-Winline \
> -	-Wredundant-decls \
> -	-Wstrict-prototypes \
> -	-Wmissing-prototypes \
> -	-Wmissing-declarations
> +libmars_la_SOURCES =                   \
> + mars.c                                \
> + mars_elf.c                            \
> + mars_mutex.c                          \
> + mars_workload_queue.c                 \
> + mars_task.c                           \
> + mars_task_barrier.c                   \
> + mars_task_event_flag.c                \
> + mars_task_queue.c                     \
> + mars_task_semaphore.c                 \
> + mars_task_signal.c
(snip)
> -libmars_la_SOURCES = \
> -	mars.c \
> -	mars_elf.c \
> -	mars_mutex.c \
> -	mars_workload_queue.c \
> -	mars_task.c \
> -	mars_task_barrier.c \
> -	mars_task_event_flag.c \
> -	mars_task_queue.c \
> -	mars_task_semaphore.c \
> -	mars_task_signal.c

Some of these are just indentation changes. Are there any strict rules
of indentation of Makefile? Otherwise, I suggest keeping the original one.

> --- a/src/mpu/kernel/Makefile.am
> +++ b/src/mpu/kernel/Makefile.am

Ditto.

> --- a/src/mpu/lib/Makefile.am
> +++ b/src/mpu/lib/Makefile.am

Ditto.

-- 
(ASAYAMA Kazunori
        (asayama at sm.sony.co.jp))
t