[Cbe-oss-dev] [PATCH 10/10 V2] MARS: workload type move from context to queue block

Yuji Mano Yuji.Mano at am.sony.com
Thu Aug 14 08:33:05 EST 2008


Hi Geoff.

Geoff Levand wrote:
> But this is not quite the same.  Here we have a union of the workload context
> and a task context.  A C++ derived type is a containment and would be more like
> 
> struct mars_task_context {
>   struct mars_workload_context base;
>   ...
> };
> 
> Then the base member would be passed.
> 
> I think to have more strict typing you could use something like the union
> you originally had, but pulled out of the workload context:
> 
> union mars_workload_type {
>   struct mars_workload_context workload;
>   struct mars_task_context task;
> };

Yes I was considering a similar solution.
I like the suggestion and plan to follow it.
I will have a separate patch for it some time soon.
I think that patch should address most of the issues you have pointed out.
Thanks for the feedback and comments.

Regards,
Yuji





More information about the cbe-oss-dev mailing list