[Cbe-oss-dev] [PATCH 10/10] MARS: workload type move from context to queue block

Yuji Mano Yuji.Mano at am.sony.com
Thu Aug 7 04:18:34 EST 2008


Geoff Levand wrote:
> Running this through checkpatch gives me this:
>  
> WARNING: externs should be avoided in .c files
> #298: FILE: src/mpu/kernel/mars_kernel_workload.c:43:
> +extern uint8_t workload_type;
> 
> ERROR: space required before the open parenthesis '('
> #307: FILE: src/mpu/kernel/mars_kernel_workload.c:69:
> +       switch(workload_type) {
> 
> ERROR: space required before the open parenthesis '('
> #319: FILE: src/mpu/kernel/mars_kernel_workload.c:82:
> +       switch(workload_type) {
> 
> ERROR: space required before the open parenthesis '('
> #331: FILE: src/mpu/kernel/mars_kernel_workload.c:95:
> +       switch(workload_type) {
> 
> ERROR: space required before the open parenthesis '('
> #347: FILE: src/mpu/kernel/mars_kernel_workload.c:112:
> +       switch(workload_type) {
> 
> ERROR: space required before the open parenthesis '('
> #378: FILE: src/mpu/kernel/mars_kernel_workload.c:164:
> +               switch(schedule_workload_type) {
> 
> ERROR: space required before the open parenthesis '('
> #391: FILE: src/mpu/kernel/mars_kernel_workload.c:315:
> +       switch(workload_type) {
> 
> total: 6 errors, 1 warnings, 476 lines checked

Thanks. Since the problem is in the base source and not
the patch I will provide a separate patch to fix this.

I am working on a patch revision for the other issues you
pointed out.

Regards,
Yuji




More information about the cbe-oss-dev mailing list