[Cbe-oss-dev] [PATCH 2/10] MARS: debug code cleanup

[Geoff Levand]

Yuji Mano wrote:
> This removes the debug MARS_PRINT_WORKLOAD_CONTEXT macro.
> This removes the debug timer call inside the kernel scheduler.
> This fixes the MARS_TIMER_STOP debug timer macro to print out results even when
> MARS_DEBUG_ENABLE_PRINT is disabled.
> 
> Signed-off-by: Yuji Mano <yuji.mano at am.sony.com>
> 
> ---
>  include/common/mars/mars_debug.h       |   12 ------------
>  src/mpu/kernel/mars_kernel_scheduler.c |    4 ----
>  2 files changed, 16 deletions(-)
> 
> --- a/include/common/mars/mars_debug.h
> +++ b/include/common/mars/mars_debug.h
> @@ -180,18 +180,6 @@ extern "C" {
>  	__PRINT__("===\n");\
>  }
>  
> -#define MARS_PRINT_WORKLOAD_CONTEXT(workload_context) {\
> -	__PRINT__("===\n");\
> -	__PRINT__("- Workload Context (%p)\n", (workload_context));\
> -	__PRINT__("-  type:  %d\n",(workload_context)->type);\
> -	switch ((workload_context)->type) {\
> -	case MARS_WORKLOAD_TYPE_TASK:\
> -	MARS_PRINT_TASK_CONTEXT(&(workload_context)->type_context.task);\
> -	break;\
> -	}\
> -	__PRINT__("===\n");\
> -}
> -
>  #define MARS_PRINT_WORKLOAD_QUEUE_HEADER(queue_header) {\
>  	__PRINT__("===\n");\
>  	__PRINT__("- Workload Queue Header (%p)\n", (queue_header));\
> --- a/src/mpu/kernel/mars_kernel_scheduler.c
> +++ b/src/mpu/kernel/mars_kernel_scheduler.c
> @@ -233,8 +233,6 @@ int scheduler(void)
>  {
>  	int status;
>  
> -	MARS_TIMER_START(Scheduler);
> -
>  	/* dma in queue header */
>  	mars_dma_get_and_wait(&queue_header,
>  			kernel_params.workload_queue_ea +
> @@ -257,8 +255,6 @@ int scheduler(void)
>  	if (status == MARS_WORKLOAD_RESERVED_NONE)
>  		return MARS_KERNEL_STATUS_IDLE;
>  
> -	MARS_TIMER_STOP(Scheduler);
> -
>  	/* run the reserved workload */
>  	workload_run();

In general, all these preprocessor macros are undesirable.  At
least the ones that can be should be converted to inline C functions.