[Cbe-oss-dev] [PATCH] ps3disk: Remove superfluous cast

Jens Axboe jens.axboe at oracle.com
Sun Apr 27 20:35:34 EST 2008


On Wed, Apr 23 2008, Geert Uytterhoeven wrote:
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
> 
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).
> 
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com>
> Acked-by: Christoph Hellwig <hch at lst.de>
> ---
> Please apply, thx!

Applied

-- 
Jens Axboe




More information about the cbe-oss-dev mailing list