[Cbe-oss-dev] [PATCH 1/8] spufs: Fix sputrace marker parameters

[Julio M. Merino Vidal]

On Fri, Apr 25, 2008 at 02:09:27PM +0200, Christoph Hellwig wrote:
> On Fri, Apr 25, 2008 at 12:07:22PM +0200, jmerino at ac.upc.edu wrote:
> > The markers facility defines the marker parameters to be of the form
> > 'name %format'.  Fix the markers in spufs to follow this syntax instead
> > of just specifying the '%format' part.
> 
> How is this a fix?  The matching happens based on the format string
> so names don't really matter.

It is how the markers documentation (Documentation/markers.txt) says that
markers should be defined, and adding the names makes things clearer because
you can quickly know what each parameter refers to.

And if the parameter ever changes the meaning (keeping the format),
applications using the marker will be able to know that because the name
would have changed.

lttng patches all put the name in the marker's format.  I don't see why
spufs should not follow the rules and be different from all other markers.

-- 
Julio M. Merino Vidal <jmerino at ac.upc.edu>