[Cbe-oss-dev] [PATCH 6/8] spufs: Remove the spu_context{, _nospu}_trace macros

[Christoph Hellwig]

On Fri, Apr 25, 2008 at 12:07:27PM +0200, jmerino at ac.upc.edu wrote:
> Drop the spu_context{,_nospu}_trace macros and use trace_mark directly.
> The macros had few flexibility in the sense that they imposed all markers
> to receive either a context pointer or a context+spu pointer pair.
> 
> We must be able to log other information aside from these two types to get
> really useful traces, and if we used macros, we'd need to add many more
> to cover all cases.
> 
> It is better to just use trace_mark by hand so that each marker can carry
> its own format.  Furthermore, it is expected that the kernel will gain
> markers everywhere at some point, and having macros just in spufs while
> the other code uses trace_mark will make things confusing.

Using these macros means we have standard traces at hand easily.  You
are of course free to add more complex trace_marks in other places, but
you'll also need more complicated than standard handles in that case.