[Cbe-oss-dev] [PATCH 3/3] spufs context switch - fix interrupt routing

Luke Browning lukebr at linux.vnet.ibm.com
Thu Apr 24 21:49:07 EST 2008


On Thu, 2008-04-24 at 12:54 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2008-04-23 at 23:32 -0300, Luke Browning wrote:
> > > A different one (issue) as these are separate handlers altogether
> > and
> > > don't muck up with CSA fields etc...
> > 
> > Separate handlers, but they both mess with csa, so this is another
> > issue.
> 
> I'll have to have a look :-) I haven't looked closely at the class_0
> lately. Do they mess with the same part of the CSA ?
> 

yup.  dar and dsisr.  

Simple fix is to just have dedicated fields for each class.

Do you think it is worth it to have both Jeremy's fix in the interrupt
handler and my fix that re-routes interrupts in the heart of the context
switch code when the mfc is quiescent.  The latter fix may not be
strictly necessary, but it is a saner approach and it should minimize if
not eliminate the occurrence of back to back interrupts being delivered
to different cpus.  After all, we are only seeing these failures when
context switching.   

Luke




More information about the cbe-oss-dev mailing list