[Cbe-oss-dev] [PATCH 1/2] edac: Add Cell XDR memory definition

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Oct 3 21:24:16 EST 2007


On Wed, 2007-10-03 at 12:19 +0200, Segher Boessenkool wrote:
> > --- linux-work.orig/drivers/edac/edac_mc_sysfs.c	2007-10-03 
> > 14:17:06.000000000 +1000
> > +++ linux-work/drivers/edac/edac_mc_sysfs.c	2007-10-03 
> > 14:17:12.000000000 +1000
> > @@ -73,7 +73,8 @@ static const char *mem_types[] = {
> >  	[MEM_RMBS] = "RMBS",
> >  	[MEM_DDR2] = "Unbuffered-DDR2",
> >  	[MEM_FB_DDR2] = "FullyBuffered-DDR2",
> > -	[MEM_RDDR2] = "Registered-DDR2"
> > +	[MEM_RDDR2] = "Registered-DDR2",
> > +	[MEM_RDDR2] = "XDR"
> 
> [MEM_XDR] = "XDR" ?  I wonder why your compiler didn't complain (it 
> isn't
> an error, but it should be a warning).

Yeah, looks like I screwed up on this one. It's a quick forward port of
a working patch I had laying around for some time and already 2 bugs in
such a small thing, doesn't look good :-) Looks like it wasn't my day
for hacking.

I'll get it fixed up tomorrow.

Ben.





More information about the cbe-oss-dev mailing list