[Cbe-oss-dev] ps3fb.c changes and black borders

Goffredo Marocchi panajev at gmail.com
Sat Nov 24 00:04:17 EST 2007


Hello,

I have noticed the latest changes regarding the fb driver in the git repo:

(small portion)

"
-struct ps3fb_res_table {
-       u32 xres;
-       u32 yres;
-       u32 xoff;
-       u32 yoff;
-       u32 type;
-};
-#define PS3FB_RES_FULL 1
-static const struct ps3fb_res_table ps3fb_res[] = {
-       /* res_x,y   margin_x,y  full */
-       {  720,  480,  72,  48 , 0},
-       {  720,  576,  72,  58 , 0},
-       { 1280,  720,  78,  38 , 0},
-       { 1920, 1080, 116,  58 , 0},
"

A lot of us could not use the FULL SCREEN option because of overscan 
issues on our TV's but then the regular modes would have very thick 
black borders around the picture which wasted a lot of TV screen estate.

Editing the margin_x and margin_y in that table as well as appropriately 
modifying the related line(s) in this table:

"

static const struct fb_videomode ps3fb_modedb[] = {

/* 60 Hz broadcast modes (modes "1" to "5") */
{
/* 480i */
"480i", 60, 576, 384, 74074, 130, 89, 78, 57, 63, 6,
FB_SYNC_BROADCAST, FB_VMODE_INTERLACED
}, {
/* 480p */
"480p", 60, 576, 384, 37037, 130, 89, 78, 57, 63, 6,
FB_SYNC_BROADCAST, FB_VMODE_NONINTERLACED
}, {
/* 720p */
"720p", 60, 1208, 684, 13481, 298, 148, 57, 44, 80, 5,
FB_SYNC_BROADCAST, FB_VMODE_NONINTERLACED
}, {
/* 1080i */
"1080i", 60, 1688, 964, 13481, 264, 160, 94, 62, 88, 5,
FB_SYNC_BROADCAST, FB_VMODE_INTERLACED
}, {
/* 1080p */
"1080p", 60, 1688, 964, 6741, 264, 160, 94, 62, 88, 5,
FB_SYNC_BROADCAST, FB_VMODE_NONINTERLACED

},

"

http://forum.beyond3d.com/showthread.php?t=43859

Modifying both tables appropriately a user could minimize those black 
borders.

Am I right saying that with the new ps3fb.c file we won't be able to 
pull that "hack" any longer ?

Will there be a different/better way to achieve our goal of minimal and 
not over conservative black borders ?

Thank you,

Goffredo Marocchi



More information about the cbe-oss-dev mailing list