[Cbe-oss-dev] PATCH [2/7] class 0 and 1 rework [Updated]

[Luke Browning]

On Wed, 2007-11-07 at 10:30 +0100, Arnd Bergmann wrote:
> On Wednesday 07 November 2007, Jeremy Kerr wrote:
> > > +     if (stat) {
> > > +             if (ctx->flags & SPU_CREATE_EVENTS_ENABLED) {
> > > +                     if (stat & 1)           /* invalid DMA alignment */
> > > +                             ctx->event_return |= SPE_EVENT_DMA_ALIGNMENT;
> > > +
> > > +                     if (stat & 2)           /* invalid MFC DMA */
> > > +                             ctx->event_return |= SPE_EVENT_INVALID_DMA;
> > > +
> > > +                     if (stat & 4)           /* error on SPU */
> > > +                             ctx->event_return |= SPE_EVENT_SPE_ERROR;
> > > +
> > > +                     wake_up_all(&ctx->stop_wq);
> > 
> > Also, what do we expect to have on the stop_wq at this point? To get to 
> > this code, we have already hit the spufs_stop_callback, which has just 
> > done a wake_up_all(&ctx->stop_wq). In fact, that's what woke this 
> > thread up.
> > 
> > Or is this intended to catch anything that's added to the stop_wq 
> > between these events? If so, I'll add a comment here.
> > 
> 
> I would guess that it's a cut+paste error that was present in my original
> patch. It looks harmless but should be removed AFAICS.
> 
> Good catch!
> 
> 	Arnd <><

Yes, I just copied that from the original code.  I guess the new code is
bug for bug compatible with the old!  Please remove it.

Luke