[Cbe-oss-dev] [PATCH] OProfile: fix Kconfig changes in the 2.6.23 kernel

[Geert Uytterhoeven]

On Wed, 31 Oct 2007, Bob Nelson wrote:
> Geert Uytterhoeven wrote:
> > On Tue, 30 Oct 2007, Bob Nelson wrote:
> >   
> > > The OPROFILE_CELL config option was deleted in a recent restructuring of
> > > the
> > > Kconfig files in the 2.6.23 kernel tree.  This will break Cell SPU
> > > profiling.
> > > This patch adds it back in as a silent option.
> > > 
> > > Signed-off-by: Bob Nelson <rrnelson at us.ibm.com>
> > >     
> > 
> > ps3_defconfig + enabling PROFILING and OPROFILE now gives:
> >   
> Have you built OProfile for PS3 before this?  If so I assume you did not set
> OPROFILE_CELL=y or you should have gotten the same build failures as far as I

Probably not. I just had `OPROFILE=m' in my current .config and after your
patch it no longer built.

But now I remember it failed to build with OPROFILE_CELL=y a while ago.

> can tell.  I can make OPROFILE_CELL depend on PPC_CELL_NATIVE which the PS3
> config does not set.  That will prevent the SPU profiling code from compiling
> and since it won't work on the PS3 that is probably a good thing...  I think
> the only thing that might work on the PS3 is timer mode on the PPU, have never
> tried it though as we don't have a PS3 handy to test it on...  I'll add the
> additional dependency to the config and repost the patch.

Sounds fine, thx!

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven at sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619