[Cbe-oss-dev] [PATCH 4/10] spidernet: zero out a pointer.

Linas Vepstas linas at austin.ibm.com
Wed May 23 09:35:18 EST 2007


On Thu, May 17, 2007 at 09:32:56AM +1000, Michael Ellerman wrote:
> > +	hwdescr->buf_addr = 0x0;
> 
> If you're going to be paranoid, shouldn't you do something here to make
> sure the value's hit the device?

I thought the whole point of paranoia is that its inexplicable.

Here's a delusional reply: I didn't see any point to it. 
1) a wmb would add overhead
2) the hardware is supposed to be looking at the status flag,
   anyway, and not misbehaving.
3) there is a wmb when the descr is actually refilled in such
   a way as to actually mean something to the hardware.

All that I really acomplished here is a minor trick to 
aid in debug printing when looking for something bad.

--linas




More information about the cbe-oss-dev mailing list