[Cbe-oss-dev] [PATCH] spidernet: skb used after netif_receive_skb

Florin Malita fmalita at gmail.com
Thu May 17 11:39:31 EST 2007


The stats update code in spider_net_pass_skb_up() is touching the skb 
after it's been passed up to the stack. To avoid that, just update the 
stats first.


Signed-off-by: Florin Malita <fmalita at gmail.com>
---

 spider_net.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
index 108adbf..1df2f0b 100644
--- a/drivers/net/spider_net.c
+++ b/drivers/net/spider_net.c
@@ -1013,12 +1013,12 @@ spider_net_pass_skb_up(struct spider_net_descr *descr,
 		 */
 	}
 
-	/* pass skb up to stack */
-	netif_receive_skb(skb);
-
 	/* update netdevice statistics */
 	card->netdev_stats.rx_packets++;
 	card->netdev_stats.rx_bytes += skb->len;
+
+	/* pass skb up to stack */
+	netif_receive_skb(skb);
 }
 
 #ifdef DEBUG




More information about the cbe-oss-dev mailing list