[Cbe-oss-dev] [PATCH] spu_priv1: fix compiler warnings

Geoff Levand geoffrey.levand at am.sony.com
Thu May 17 11:08:23 EST 2007


Arnd Bergmann wrote:
> On Wednesday 16 May 2007, Michael Ellerman wrote:
>>   On Wed, 2007-05-16 at 11:59 +1000, Jeremy Kerr wrote:
>> > Christoph,
>> > 
>> > > spu_priv1.h has various prototypes containing spu_context pointers,
>> > > but no foward declarations for it. �This patch fixes the warnings by
>> > > providing a forward declaration.
>> > 
>> > Looks good.
>> > 
>> > Acked-by: Jeremy Kerr <jk at ozlabs.org>
>> 
>> Does that mean you've merged it into your tree .. or Arnd should merge
>> it .. or Paulus should merge it .. or ?
> 
> Actually, the bug fixed by this particular patch comes in through geoff's
> tree, which I have in mine right now, so it should go to him.
> 
> The real fix is different though, once the ps3 port has solved the problem
> of the PS mapping, the hack won't be needed any more. The priv1 mapping
> stuff doesn't have anything to do with an spu_context, which is a
> hight-level construct.

Since this is a small fix for a temporary work-around, I just folded it into
the existing patch.  

Arnd, please update the version in your series.

http://git.kernel.org/?p=linux/kernel/git/geoff/ps3-linux-patches.git;a=blob;f=ps3-wip/spufs-wrap-master-run-bit.diff

-Geoff





More information about the cbe-oss-dev mailing list