[Cbe-oss-dev] [PATCH 2/10] spidernet: beautify error messages

[Michael Ellerman]

On Wed, 2007-05-16 at 17:00 -0500, Linas Vepstas wrote:
> Make error messages print which interface they apply to.
> 
> Signed-off-by: Linas Vepstas <linas at austin.ibm.com>
> 
> ----
>  drivers/net/spider_net.c |   10 ++++++----
>  drivers/net/spider_net.h |    2 +-
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6.22-rc1/drivers/net/spider_net.c
> ===================================================================
> --- linux-2.6.22-rc1.orig/drivers/net/spider_net.c	2007-05-14 17:05:03.000000000 -0500
> +++ linux-2.6.22-rc1/drivers/net/spider_net.c	2007-05-15 14:47:38.000000000 -0500
> @@ -433,7 +433,8 @@ spider_net_prepare_rx_descr(struct spide
>  	descr->skb = dev_alloc_skb(bufsize + SPIDER_NET_RXBUF_ALIGN - 1);
>  	if (!descr->skb) {
>  		if (netif_msg_rx_err(card) && net_ratelimit())
> -			pr_err("Not enough memory to allocate rx buffer\n");
> +			pr_err("%s: Not enough memory to allocate rx buffer\n",
> +			    card->netdev->name);

Isn't that what dev_err() is for?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070517/de34cd32/attachment.pgp>