[Cbe-oss-dev] [PATCH] Fixes for libspe-1.2.0 build-time warnings

Julio M. Merino Vidal jmerino at ac.upc.edu
Wed Mar 21 02:20:24 EST 2007


On 20/03/2007, at 13:43, Julio M. Merino Vidal wrote:

> Hello,
>
> Here go some patches to fix several warnings when building libspe  
> (both for the -m32 and -m64 cases).  These are, specially, to  
> resolve issues when -DDEBUG is given.  They also fix a problem with  
> the DEBUG_PRINTF macro that arose in custom code; more details are  
> given in the logs.
>
> I'm wondering if these changes could be incorporated upstream.
>
> Note that, although the changes work, some chunks of patch2.diff  
> feel quite ugly.  There are problems when converting from pointers  
> to integers, for example, and I haven't found a clean way to do  
> that.  (There is a "vaddr_t" type in NetBSD that can be used for  
> exactly this purpose, though it seems to be missing in Linux.)  If  
> these can be improved in some way, please tell me and I can  
> readjust the patch.

I've received some comments privately that mention how to resolve  
this (thanks!).  Add the attached patch (patch4.diff) to the mix, to  
be applied after patch2.diff.  (I could publish the git tree I  
created for libspe if that is desired by whoever has to manage these  
patches.)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch4.diff
Type: application/octet-stream
Size: 2101 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070320/8b3df577/attachment.obj>
-------------- next part --------------

-- 
Julio M. Merino Vidal <jmerino at ac.upc.edu>




More information about the cbe-oss-dev mailing list