[Cbe-oss-dev] [PATCH] enable SPU coredump for kernel-builtin spufs

[Arnd Bergmann]

On Tuesday 13 March 2007, Akinobu Mita wrote:
> SPU coredump code cannot be called when spufs is built is built
> into kernel.

Right, this looks broken.

> Index: 2.6-git-ps3/arch/powerpc/platforms/cell/spu_coredump.c
> ===================================================================
> --- 2.6-git-ps3.orig/arch/powerpc/platforms/cell/spu_coredump.c
> +++ 2.6-git-ps3/arch/powerpc/platforms/cell/spu_coredump.c
> @@ -36,7 +36,7 @@ int arch_notes_size(void)
>  
>         ret = -ENOSYS;
>         mutex_lock(&spu_coredump_mutex);
> -       if (owner && try_module_get(owner)) {
> +       if (try_module_get(owner)) {
>                 ret = spu_coredump_calls.arch_notes_size();
>                 module_put(owner);
>         }

This now breaks the modular case, since in the modular case, you
now call into a nonexisting function after unloading spufs.

	Arnd <><