[Cbe-oss-dev] [PATCH 3/3] libspe2: Clean up proxy DMA and add error checks

[Gerhard Stenzel]

> This patch modifies proxy DMA implementation in libspe2 as following:
>
>   - share the same code between 'get' and 'put'
>   - make scope of variables smaller
>   - add missing error checks
>
> Signed-off-by: Kazunori Asayama <asayama at sm.sony.co.jp>

Apologies for taking longer to review this one, as it changes quite a bit.
Overall it looks good to me and the right way to go, so please go ahead and
apply.

One thing I noticed:

> +   /* tag 16-31 are reserved by kernel */
> +   if (tag > 0x0f || tid > 0xff || rid > 0xff) {
> +      errno = EINVAL;
> +      return -1;
> +   }

I failed to find these limits in the API spec. Maybe we should add them?

Best regards,

Gerhard Stenzel, Linux on Cell Development, LTC
-----------------------------------------------------------------------------------------------------------------------------------

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Herbert
Kircher
Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart,
HRB 243294