[Cbe-oss-dev] [patch 1/5] cell: pmi remove support for mutiple devices.

Akinobu Mita mita at fixstars.com
Mon Jun 25 11:44:42 EST 2007


>> > -kfree(dev->dev.driver_data);
>> > +kfree(data);
>>
>> Shouldn't it set data = NULL here?
>>
>> I guess we will get "pmi: driver has already been initialized" message
>> and -EBUSY on reloading pmi driver.
>>
>> >
>> >  return 0;
>> >  }
>
> That problem did actually not occur.
> Anyway, I added the line for completeness and consistency.

The data is located in module data. So unloading module clean up
the data, too. I missed it.

In order to test the problem I said, we need to re-probe pmi driver
without unloading pmi driver. (http://lwn.net/Articles/143397/)

I hope your updated version of patch fixes the problem.




More information about the cbe-oss-dev mailing list