[Cbe-oss-dev] [PATCH] fix cbe_reg.c for "old" SLOF tree.

[Jean-Christophe Dubois]

On Friday 22 June 2007 20:43:37 Arnd Bergmann wrote:
> On Thursday 21 June 2007, Jean-Christophe Dubois wrote:
> > Some SLOF device trees have a "be" node but no "cpus" properties under
> > it.
> >
> > So le'ts fix the crash until the device tree is fixed.
> >
> > Signed-off-by: Jean-Christophe DUBOIS <jcd at tribudubois.net>
>
> The patch looks good in principle, but I'd prefer to print a warning
> message here, so the error doesn't silently get ignored, same for the
> other patches.

I guess it is debatable if this is an "error". It is just not the latest 
incarnation of the SLOF device tree ... some kind of legacy ...

But sure we could put a warning here. I'll resubmit the patches with warning 
(if this is OK with you)

JC

> If a warning is already printed earlier when the tree is scanned, that
> would be fine as well.


>
> 	Arnd <><
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev