[Cbe-oss-dev] [PATCH 4/15] spidernet: silence the ramfull messages

Linas Vepstas linas at austin.ibm.com
Fri Jun 15 08:29:43 EST 2007


On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >--- linux-2.6.22-rc1.orig/drivers/net/spider_net.c	2007-06-11 
> >10:02:34.000000000 -0500
> >+++ linux-2.6.22-rc1/drivers/net/spider_net.c	2007-06-11 
> >11:45:25.000000000 -0500
> >@@ -1172,7 +1172,7 @@ spider_net_decode_one_descr(struct spide
> > 		goto bad_desc;
> > 	}
> > 
> >-	if (hwdescr->dmac_cmd_status & 0xfefe) {
> >+	if (hwdescr->dmac_cmd_status & 0xfcf4) {
> > 		pr_err("%s: bad status, cmd_status=x%08x\n",
> > 			       card->netdev->name,
> > 			       hwdescr->dmac_cmd_status);
> 
> 
> A follow-up patch needs to remove the above magic numbers (==numeric 
> constants), replacing them with named constants

I thought laziness was a virtue ... oh, wait, wrong programming language.

Patch coming shortly.

--linas



More information about the cbe-oss-dev mailing list