[Cbe-oss-dev] [patch 1/3] powerpc: fix pci_setup_phb_io_dynamic for pci_iomap

Arnd Bergmann arnd at arndb.de
Tue Jun 5 08:27:06 EST 2007


On Tuesday 05 June 2007, Benjamin Herrenschmidt wrote:
> 
> On Mon, 2007-06-04 at 20:14 +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd.bergmann at de.ibm.com>
> > We had a problem on a system with only dynamically allocated
> > PCI buses (using of_pci_phb_driver) in combination with libata.
> > This setup ended up having no "primary" phb, which means
> > that pci_io_base never got initialized and all IO port
> > numbers are 64 bit numbers, which is larger than the
> > PIO_MASK limit.
> 
> That's for 2.6.22 ? I wonder if a better fix is to initialize
> pci_io_base statically and clear it in iSeries code... didn't I post a
> patch for that a while ago ?

We talked about this, but I can't find a patch from you that did this.
Either way should be fine, mine may be slightly less invasive, while
statically initializing pci_io_base is what you also do in your
rewrite of that code for 2.6.23.

	Arnd <><



More information about the cbe-oss-dev mailing list