[Cbe-oss-dev] [PATCH 3/3] spufs: catch nosched contexts in spu_deactivate

[Christoph Hellwig]

On Mon, Jun 04, 2007 at 05:09:43PM +0200, Arnd Bergmann wrote:
> On Monday 04 June 2007, Christoph Hellwig wrote:
> > spu_deactivate should never be called for nosched contets. ?Put in
> > a check so we can print a stacktrace and exit early in case it
> > happes errornously.
> 
> Doesn't this conflict with the first patch in this series?
> The core dump code actually calls spu_acquire_saved(), because
> it needs to read the 'regs' file and others that can only
> be accessed on a deactivated context. At least I believe
> that this was the original reason for disallowing core
> dumps on nosched contexts.

True.  Please drop the first patch - I'll send one to add a comment
about why we're skipping it instead.  Alternatively we could make
sure to never try to dump the files that aren't actually present for
nosched contexts.