[Cbe-oss-dev] [PATCH] cell: move SPU affinity init code to a separate file

André Detsch adetsch at br.ibm.com
Tue Jul 31 01:10:59 EST 2007


Arnd Bergmann wrote:
> Right, that is a bug. The same function also is broken if the first NUMA
> node doesn't have an SPUs, and it returns an incorrect information if the
> first SPU on the first node does not have a vicinity property but all the
> other have one.
> 
> It should probably be something like
> 
> 	of_for_each_node_by_type(dn, "spe") {
> 		if (of_find_property(dn, "vicinity", NULL))  {
> 			of_node_put(dn);
> 			return 1;
> 		}
> 	}
> 	return 0;

Yes, that seems to be more correct. Tested here, and sending a patch in 
a few seconds.

--
Andre Detsch




More information about the cbe-oss-dev mailing list