[Cbe-oss-dev] [PATCH] cell: move SPU affinity init code to a separate file

André Detsch adetsch at br.ibm.com
Thu Jul 26 13:03:55 EST 2007


Christoph Hellwig wrote:
> On Tue, Jul 24, 2007 at 01:21:12PM -0700, Geoff Levand wrote:
>> Without really knowing the intent of this functionality, I would
>> say the proper way is to create a new method in struct spu_management_ops,
>> maybe say init_affinity, and call it at the appropriate point in
>> init_spu_base().  The PS3 implementation of the method would be empty.
> 
> That's what Andre suggested initially.  I told him that using a separate
> initcall would be simpler which I still think it is.  If you feel
> strongly about adding a method I wouldn't mind doing that either.

Ok, just sent a patch moving the code to a new spu_management_ops 
function. It is implies changes at more files, if compared to the 
initcall option, but, of course, nothing complex. I'm ok with both 
implementations.

--
Andre Detsch



More information about the cbe-oss-dev mailing list