[Cbe-oss-dev] [PATCH] cell: move SPU affinity init code to a separate file

[Arnd Bergmann]

On Wednesday 25 July 2007, Michael Ellerman wrote:
> On Tue, 2007-07-24 at 11:36 -0300, Andre Detsch wrote:

> >  
> > -spu-manage-$(CONFIG_PPC_CELLEB)		+= spu_manage.o
> > -spu-manage-$(CONFIG_PPC_CELL_NATIVE)	+= spu_manage.o
> > +spu-manage-$(CONFIG_PPC_CELLEB)		+= spu_manage.o spu_affinity.o
> 
> Does it really work on CELLEB? Why is CELLEB stuff in here anyway?

Celleb has a fixed set of SPUs at boot time, like the IBM blades, so it's
running the same code for parsing the device tree. It should however not need
to go through the compatibility code for QS20, so we don't want that compiled
in when building _only_ for celleb.

> > +	return of_find_property(spu_devnode(spu), "vicinity", NULL) != NULL;
> > +}
> 
> What is the difference between vicinity and affinity?
 
Vicinity is the relative location of SPUs as described in the device tree.
Affnity is what the user specifies to the kernel for contexts.

Full ack on all your other comments.

	Arnd <><