[Cbe-oss-dev] fix spu build errors on ps3

Christoph Hellwig hch at lst.de
Sat Jul 21 22:46:54 EST 2007


On Fri, Jul 20, 2007 at 04:59:20PM -0700, Geoff Levand wrote:
> Hi Andre.
> 
> Commit 3ad216cae837d90415c605e1149e6fd88f51c973 added some Cell Blade
> specific routines to spu_base.c that are not available on ps3. This
> hacked patch removes the references so that builds for CONFIG_PPC_PS3
> can succeed.
> 
> Please re-work the removed code to properly support multi-platform
> execution.  Platform specific routines go into spu_manage.c and are
> called through the struct spu_management_ops.
> 
> To test it I recommend you at least build with ps3_defconfig.

I think moving that code to a file of it's own would be best.  That
also allows adding a config option for it so that people having blades
with the updated OF don't have to build it.




More information about the cbe-oss-dev mailing list