[Cbe-oss-dev] [PATCH 0/7] libspe2: Hide internal symbols

[Kazunori Asayama]

Christoph Hellwig <hch at lst.de> wrote:
> On Thu, Jul 19, 2007 at 10:20:27PM +0900, Kazunori Asayama wrote:
> > This series of patches adds 'static' modifiers or appropriate prefixes
> > to internal symbols in libspe2, so that they are hidden from the
> > outside of the library.
> > 
> > OK to apply ?
> 
> Nice that someone does this work.  Any chance you'd also be interested
> in -fvisibility and elf symbol version to make sure none but the proper
> ABIs leak outside?

It sounds good to me, and indeed I considered similar thing to your
suggestion before. But I gave up doing that, since libspe12 (libspe
1.2 wrapper) refered to many of the internal symbols.

So we will need some additional works to eliminate such dependency,
before hiding the internal symbols completely, e.g.:

  a. implement the libspe12 wrapper on the top of libspe2's external
     interface, or
  b. discard the libspe12 wrapper.

In my personal opinion, I prefer the option b, because libspe 1.x is
deprecated and it's discouraged to continue using it, and because we
have another more perfectly libspe1-compatible implementation for
backward compatibility... i.e. the 'true' libspe 1.2 itself.

--
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t