On Wed, 18 Jul 2007 18:04:46 +0200 Arnd Bergmann <arnd at arndb.de> wrote: > + if (!cpu_handle) { > + WARN_ON_ONCE(!cpu_handle); > + continue; > + } fyi, WARN_ON(expr) and WARN_ON_ONCE(expr) now return `expr', so this could have been more neatly coded as if (WARN_ON_ONCE(!cpu_handle)) continue;