[Cbe-oss-dev] [PATCH 1/2] spufs: Make signal-notification files readonly for NOSCHED contexts

[Christoph Hellwig]

On Mon, Jul 16, 2007 at 09:14:46PM +0200, Arnd Bergmann wrote:
> On Monday 16 July 2007, Jeremy Kerr wrote:
> > Reading from the signal{1,2} files requires a spu_acquire_saved, so
> > mask out the read bits for contexts created with SPU_CREATE_NOSCHED.
> > 
> > Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> 
> Can't the owner of the files simply change the file attributes again?
> I think it would be better to have another set of file_operations
> for these two files in case of NOSCHED contexts.

spufs_setattr doesn't block any mode changes, so that's true and we'll
actually need a different set of file_operations.