[Cbe-oss-dev] [PATCH] spufs: add spu stats in sysfs and ctx stat file in spufs

Christoph Hellwig hch at lst.de
Tue Jul 17 23:06:38 EST 2007


On Mon, Jul 16, 2007 at 03:32:41PM +1000, Jeremy Kerr wrote:
> From: Andre Detsch <adetsch at br.ibm.com>
> 
> This patch exports per-context statistics in spufs as long as spu
> statistics in sysfs.
> 
> It was formed by merging:
> "spufs: add spu stats in sysfs"   From: Christoph Hellwig
> "spufs: add stat file to spufs"   From: Christoph Hellwig
> "spufs: fix libassist accounting" From: Jeremy Kerr
> "spusched: fix spu utilization statistics" From: Luke Browning
> And some adjustments by myself, after suggestions on cbe-oss-dev.
> 
> Having separate patches was making the review process harder
> than it should, as we end up integrating spus and ctx statistics
> accounting much more than it was on the first implementation.
> 
> Signed-off-by: André Detsch <adetsch at br.ibm.com>
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> 
> ---
> 
> Updated to apply on to current spufs & powerpc trees, which already
> have some of the above patches. André - could you check this for
> sanity?
> 
> If this is OK with André, it'd be a good contender for 2.6.23.

If there's any chance I'd see the actual fixed stats go in as one patch
instead of the current mess with half a dozend patches backing things
out and adding them back.  I'd be fine with 2.6.23, but we need some
documentation for it.  I previously planned creating a text file
based on the ibm design document, but the code is completely out of
sync with that one now so it'll need a rewrite first.




More information about the cbe-oss-dev mailing list