[Cbe-oss-dev] [PATCH 1/9] spufs: fix array size of channel index

[Noguchi, Masato]

(snip...)
> > -	u64 idx, ch_indices[7] = { 0UL, 3UL, 4UL, 24UL, 25UL, 27UL };
> > +	u64 idx, ch_indices[6] = { 0UL, 3UL, 4UL, 24UL, 25UL, 27UL };
> 
> Is there any reason specifying explicit array size?  To emphasise the
> number of the related registers?

Probably there is no reason to specify the number, I think.

> >  	/* Save the following CH: [0,3,4,24,25,27] */
> > -	for (i = 0; i < 7; i++) {
> > +	for (i = 0; i < 6; i++) {
> 
> How about ARRAY_SIZE() here?

Sounds reasonable.

It seems there are many other portions to apply these replacements.
So, I will make patch to fix them at the next chance to fix
spufs/switch.c.


Regards,
M.Noguchi