[Cbe-oss-dev] [patch 2/5] Add support to OProfile for profiling Cell/B.E. SPUs

[Maynard Johnson]

Olof Johansson wrote:

> On Tue, Jul 03, 2007 at 01:04:27PM -0500, Maynard Johnson wrote:
> 
>>Hi, Olof,
>>We will clean up all of the style and indentation issues you mention 
>>below, so I won't comment on those individually.  See my responses to 
>>your other comments below.
> 
> 
> Thanks!
> 
> 
>>>Also, only the IBM processors have their reg_setup functions converted
>>
>>The reg_setup function is declared in 
>>include/asm-powerpc/oprofile_impl.h.  The only implementations of this 
>>function are in arch/powerpc/oprofile, and we've changed all of these. 
>>This change does not affect other architectures.
> 
> 
> The patch I commented on only changes rs64, power4 and cell. It did
> not change pa6t, 7450 or fsl_booke. That's what I meant with "non-IBM"
> processors.
Thanks for catching this!  I have no idea how these slipped through 
without us noticing.  Will fix.
> 
> 
> -Olof