[Cbe-oss-dev] [PATCH] spufs: Avoid restarting MFC in context saving

Jeremy Kerr jk at ozlabs.org
Tue Jul 3 21:27:58 EST 2007


Asayama-san,

> When saving context, save_mfc_cntl is called to suspend MFC. The
> suspend_mfc is used to restore context (and isolation mode support).
> So the DMA has already been suspended when halt_mfc_decr is called,
> and we must use Sm bit in halt_mfc_decr in order to keep that status.

Silly me, was under the (incorrect) impression that "suspend_mfc" was 
where we suspend the mfc :)

Looking closer, you're exactly right. I think we should set Sm in 
save_mfc_cntl(), after we've saved the register to the csa. How does 
that sound?

I can do up a patch if you prefer.

Cheers,


Jeremy
(who is going to read up on the save/restore process a little more)



More information about the cbe-oss-dev mailing list