[Cbe-oss-dev] [PATCH] spufs: Avoid restarting MFC in context saving

[Jeremy Kerr]

Asayama-san,

> I think that you misunderstand the meaning of Sc bit (and Sm
> bit).

Quite possibly :)

I had the bit values of Sm reversed. So your patch is disabling the 
effect of the Sc bit. Doesn't this mean that with your patch, when we 
later try to suspend the MFC queue in suspend_mfc(), nothing will 
happen?

(Still, I think this should be kept separate from our use of the Dh bit, 
and so done somewhere other than halt_decr())

> Writing "Sc == 0" does *NOT* mean "Suspend MFC command queue 
> operation is not requested", but means "Request normal MFC command
> queue operation".

Yep. From reading the doc:

  MFC suspended = ~Sm & Sc

So why don't we just leave Sm at 0, and alter Sc when we need to 
suspend? If your patch fixes the bug, doesn't that make the CBEA doc 
wrong?

> Yes, I have. I'll submit it to this ML later.

Great, thanks.


Jeremy