[Cbe-oss-dev] [PATCH/RFC] libspe2: add support for multi source sync

Arnd Bergmann arnd at arndb.de
Mon Jul 2 20:28:45 EST 2007


On Friday 29 June 2007, Gerhard Stenzel wrote:
> The following patch/RFC adds and implements two API functions
> to support the MFC Multisource Synchronization facility.
> 
> Signed-off-by: Gerhard Stenzel <stenzel at de.ibm.com>

Do you have a test case for this? Since the kernel currently
is missing support for MSS read/write operations, I guess that
there should also be a bug report so we don't forget to fix
this in the kernel again.

Your patch looks good, except for the broken use of 'volatile'
(which doesn't prevent mmio accesses from getting moved outside
of spinlocks), but we should probably clean that up all at once,
since libspe2 still does it this way everywhere in the code.

	Arnd <><



More information about the cbe-oss-dev mailing list