[Cbe-oss-dev] [PATCH 9/10] spu sched: implement real runqueues

Segher Boessenkool segher at kernel.crashing.org
Mon Jan 8 10:42:12 EST 2007


>> -	wait_queue_head_t waitq[MAX_PRIO];
>> +	struct list_head rq[MAX_PRIO];
>
> Can we call this 'runq' instead?

Why not spell it out completely as "run_queue", bytes of
source code are cheap, programmer time lost to confusing
names isn't.

>> +	struct mutex mutex;
>
> and this one 'runq_mutex' ? I know it also protects the bitfield, but
> that's really part of the run queue system.

run_queue_mutex, then.


Segher




More information about the cbe-oss-dev mailing list