[Cbe-oss-dev] [PATCH] spufs: fix to reject an access when SPE touched unused stack

[Arnd Bergmann]

On Tuesday 20 February 2007 05:30, Benjamin Herrenschmidt wrote:
> >  #if 0
> >       if (expand_stack(vma, ea))
> >               goto bad_area;
> > +#else
> > +     goto bad_area;
> >  #endif /* XXX */
> >  good_area:
> >       is_write = dsisr & MFC_DSISR_ACCESS_PUT;
> 
> Arnd, any reason why we don't expand_stack ?

No, I don't think there is any reason. By the research I've done,
even the earliest version of this code that I submitted had the
#ifdef in there. The best explanation I have for this is that
expand_stack() is not exported and we forgot about sending the
patch to export it.

Since spu_base is now always compiled into the kernel, there is
no need to export it any more, and we can just remove the #if 0,
I guess.

	Arnd <><