[Cbe-oss-dev] [PATCH 4/6] spufs: extension of spu_create to support affinity definition

Arnd Bergmann arnd at arndb.de
Tue Feb 13 05:10:33 EST 2007


On Monday 12 February 2007 18:48, André Detsch wrote:
> 
> > Why do we need the extra aff_flags property? The information seems
> > a little redundant considering we already have ctx->flags and we
> > can look into list_empty(aff_list) etc.
> 
> I agree AFF_HAS_SPU_AFFINITY flag is redundant with 
> list_empty(aff_list). However, as I see, AFF_HAS_MEM_AFFINITY and 
> AFF_SUBLIST_HEAD are not.

AFF_HAS_MEM_AFFINITY is encoded in ctx->flags & SPU_CREATE_AFFINITY_MEM
(or whichever way you called it). Not sure what the best way to determine
AFF_SUBLIST_HEAD is, but I guess you could test (list_empty(aff_list) &&
!list_empty(aff_list)).

	Arnd <><



More information about the cbe-oss-dev mailing list