[Cbe-oss-dev] [PATCH] CELL PPU Oprofile cleanup patch
Carl Love
cel at us.ibm.com
Fri Feb 2 10:15:52 EST 2007
Mikey:
Yes, that is an error. Thanks for the catch.
Carl Love
On Fri, 2007-02-02 at 09:52 +1100, Michael Neuling wrote:
> Carl,
>
> > +#define NUM_TRACE_BUS_WORDS 4
> > +#define NUM_INPUT_BUS_WORDS 2
>
> <snip>
>
> > - for (i = 0; i < 4; i++)
> > + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> > trace_bus[i] = 0xff;
> >
> > - for (i = 0; i < 2; i++)
> > + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> > input_bus[i] = 0xff;
>
> The first loop looks like a bug... Shouldn't it be
> NUM_TRACE_BUS_WORDS?
>
> Mikey
More information about the cbe-oss-dev
mailing list