[Cbe-oss-dev] [PATCH] libspe2: adapt to cross toolchain location in SDK 3.0

[Arnd Bergmann]

On Thursday 06 December 2007, stenzel at de.ibm.com wrote:
> Cross toolchain of SDK 3.0 is now in /opt/cell/toolchain/
> 
> Signed-off-by: Gerhard Stenzel <stenzel at de.ibm.com>
> 
> ===================================================================
> --- /home/stenzel/workspace/libspe/libspe2/make.defines (revision 99)
> +++ /home/stenzel/workspace/libspe/libspe2/make.defines (working copy)
> @@ -23,7 +23,7 @@
>  CROSS_COMPILE = $(shell if ! grep Broadband /proc/cpuinfo ; then echo 1 ; fi)
>  
>  ifeq "$(X86)"  "1"
> -    CROSS      ?= /opt/cell/bin/ppu-
> +    CROSS      ?= /opt/cell/toolchain/bin/ppu-
>      EXTRA_CFLAGS = -m32  -mabi=altivec 
>      # RPM defined default flags may not work with this cross-compiler
>      override OPTFLAGS = 
> 

Why is the path hardcoded in there in the first place? You really shouldn't
make assumptions about the system from your package, just assume that everything
is in the current path.

In the spec file, you have build dependencies on specific packages you rely
on, and then you can override the path names on the make command.

	Arnd <><