[Cbe-oss-dev] [PATCH]:Add PM signal groups registers.

[Kevin Corry]

On Thu August 30 2007 4:53 am, Christian Krafft wrote:
> On Thu, 30 Aug 2007 12:20:17 +0900
> "takaki.azuma" <sp.2007avs.azuma at dme.toshiba.co.jp> wrote:
> >
> > Index: powerpc/arch/powerpc/platforms/cell/cbe_regs.h
> > ===================================================================
> > --- powerpc.git/arch/powerpc/platforms/cell/cbe_regs.h
> > +++ powerpc/arch/powerpc/platforms/cell/cbe_regs.h
> > @@ -248,17 +263,65 @@ struct cbe_mic_tm_regs {
> >
> >  	u64	mic_ctl_cnfg_1;					/* 0x01c0 */
> >  #define CBE_MIC_DISABLE_PWR_SAV_1	0x8000000000000000LL
> > -	u64	pad_0x01c8;					/* 0x01c8 */
> >
> > +	u64	mic_ctl_debug_1;				/* 0x01c8 */
> >  	u64	slow_fast_timer_1;				/* 0x01d0 */
> >  	u64	slow_next_timer_1;				/* 0x01d8 */
> >
> > -	u8	pad_0x01e0_0x1000[0x1000 - 0x01e0];		/* 0x01e0 */
> > +	u8	pad_0x01e0_0x0220[0x0220 - 0x01e0];		/* 0x01e0 */
> > +
> > +	u64	mic_df_debug_yrac_0;				/* 0x0220 */
> > +	u64	mic_df_debug_yrac_1;				/* 0x0228 */
> > +
> > +	u8	pad_0x0230_0x0238[0x0238 - 0x0230];		/* 0x0230 */
> > +
> > +	u64	mic_fir_debug;					/* 0x0238 */
> > +
> > +	u8	pad_0x0240_0x0ff0[0x0ff0 - 0x0240];		/* 0x0240 */
> > +
> > +	u64	tkm_pmcr;					/* 0x0ff0 */
> > +
> > +	u8	pad_0x0ff8_0x1000[0x1000 - 0x0ff8];		/* 0x0ff8 */
>
> This looks simpler this way:
> u64	pad_0x0ff8;	/* 0x0ff8 */

Likewise for pad_0x0230_0x0238. It can be simplified to:
u64 pad_0x0230; /* 0x0230 */

Thanks,
-- 
Kevin Corry
kevcorry at us.ibm.com
http://www.ibm.com/linux/