[Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Wed Aug 29 18:56:14 EST 2007


Christian Krafft wrote:
> On Thu, 23 Aug 2007 18:12:19 +0200
> Arnd Bergmann <arnd at arndb.de> wrote:
> 
> > On Thursday 23 August 2007, kou.ishizaki at toshiba.co.jp wrote:
> > > Please check "unit-id" if "physical-id" doesn't exist. Because
Celleb
> > > uses "unit-id" to provide spe_id.
> 
> Sorry for the late answer, wasn't on cc
> and had to receive all mails of the last 6 month once again :-(
> 
> Can you check if the patch below is working with celleb device tree ?
> 
> ------
> Subject: spu_manage: fix spu_unit_number for celleb device tree
> 
> From: Christian Krafft <krafft at de.ibm.com>
> 
> New device trees provide "physical-id".
> Celleb device tree provide the "unit-id".
> Legacy device tree used the reg property for the physical id of an
spe.
> This patch fixes find_spu_unit_number to look for the spu id in that
order.
> The length is checked to avoid misinterpretation in case the
attributes
> unit-id or reg do not contain the id.
> 
> Signed-off-by: Christian Krafft <krafft at de.ibm.com>

Acked-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>

It works good on Celleb, thanks.  Please apply it to 2.6.23.

Best regards,
Kou Ishizaki



More information about the cbe-oss-dev mailing list