[Cbe-oss-dev] [PATCH 9/9] Call spu_acquire_saved() before calculating the SPU note sizes

[Michael Ellerman]

On Mon, 2007-08-27 at 15:40 +0200, Christoph Hellwig wrote:
> On Fri, Aug 17, 2007 at 05:19:18PM +1000, Michael Ellerman wrote:
> > It makes sense to stop the SPU processes as soon as possible. Also if we
> > dont acquire_saved() I think there's a possibility that the value in
> > csa.priv2.spu_lslr_RW won't be accurate.
> 
> Should we really release them here, I'd rather keept them stopped until
> we're done with the coredump.

Yeah that would be nicer. Unfortunately there's no guarantee that the
second SPU coredump callback will be called, ie. if we run out of ulimit
or there's some other problem with the upper level coredump code. So
we'd end up calling acquire_saved() and not release, which would be
worse I think.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070828/18dc0ed6/attachment.pgp>