[Cbe-oss-dev] [PATCH] make arguments 64 big unconditionally

Andrew Pinski pinskia at gmail.com
Mon Aug 13 10:40:25 EST 2007


On 8/12/07, Joel Schopp <jschopp at austin.ibm.com> wrote:
> Signed-off-by: Joel Schopp<jschopp at austin.ibm.com>
>
> Index: libspe2/spebase/default_libea_handler.c

> +  if((arg0->slot[0]== 0 && arg1->slot[0] == 0) || sizeof(nmemb) == 8)
> +    calloc_addr = calloc(nmemb, size);
> +  else
> +    errno = ENOMEM;

I think setting errno is wrong here and the other places.  calloc and
malloc and realloc are not documented to change errno in C99, just
NULL or a valid memory location.

Thanks,
Andrew Pinski



More information about the cbe-oss-dev mailing list