[Cbe-oss-dev] spufs: make isolated loader properly aligned (take 2)

[Sebastian Siewior]

* Christoph Hellwig | 2007-08-11 05:56:46 [+0200]:

>On Fri, Aug 10, 2007 at 11:27:55PM +0200, Sebastian Siewior wrote:
>> According to the comment in spufs_init_isolated_loader(), the isolated loader
>> should be aligned on a 16 byte boundary. ARCH_{KMALLOC|SLAB}_MINALIGN is not
>> defined so 8 byte alignment is guaranteed.
>> This patch enforces page based alignment via vmalloc (compile time tested).
>
>Please use get_free_pages instead.  vmalloc means we need to setup
>pagetables and walk them on every access, aswell as wasting a guard page
>for every allocation.

There should be only one allocation. 
You you though about something like

 loader = __get_free_pages(GFP_KERNEL, get_order(size));

Sebastian